Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/api todos (solves #31) #35

Merged
merged 8 commits into from
Oct 24, 2023

Conversation

Mopsgeschwindigkeit
Copy link
Contributor

Summary - The What

DO -
Implemented all supported calls for the https://api.smaxtec.com/api/v2/todos endpoint.
I also moved the PublicApiV2 class to the sxapi/publicV2 directory to have better structure.

DONT - No implementation for the CLI.

Magic - The How (Optional)

DO - Created a new Class Todos and added ab attribute of that class to the PulbicApiV2 class (called todos).

Implemented it i a way that we forward all given arguments and let the API-Endpoint decide which one to use. This allows us to be compatible with updated calls in the future.

api = PublicAPIV2(api_token=<token>)

# post todo
response = api.todos.post_todos(<todo_id>, <organisation_id>, **kwargs)

ToDo's - Open Point List

DO

  • Documentation

solves #31

@Mopsgeschwindigkeit Mopsgeschwindigkeit marked this pull request as ready for review October 16, 2023 18:06
@Mopsgeschwindigkeit Mopsgeschwindigkeit changed the title Feat/api todos solves #31 Feat/api todos (solves #31) Oct 16, 2023
Copy link
Contributor

@flowolf flowolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good so far.

Just one little naming thing.

src/sxapi/publicV2/todos.py Show resolved Hide resolved
@Mopsgeschwindigkeit Mopsgeschwindigkeit merged commit e9656db into smaxtec:main Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants